Split out CI and deployment pipelines #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should do a few things: 1) Make it easier to see only the pipeline runs that are doing actual deployments to environments. Currently these are intermingled with CI test runs. 2) Disable the DB migrations check on the deployment pipeline. This check is used for CI only, because in some situations we might expect (and want) it to fail.
|
|
Put this up as an option for unblocking @srh-sloan on #208, which can't be deployed because we (intentionally) don't have migrations that cover all of the python model changes. We're going to do a deploy-with-downtime to get past this and then will regroup to fix our pipeline so that we can intentionally deploy without having up-to-date migrations (we need this in cases where we're removing columns, which should be done across multiple deployments). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This should do a few things:
Make it easier to see only the pipeline runs that are doing actual deployments to environments. Currently these are intermingled with CI test runs.
Disable the DB migrations check on the deployment pipeline. This check is used for CI only, because in some situations we might expect (and want) it to fail.